summaryrefslogtreecommitdiff
path: root/drivers/hwmon
diff options
context:
space:
mode:
authorOsama Muhammad <osmtendev@gmail.com>2023-05-26 19:39:38 +0300
committerGuenter Roeck <linux@roeck-us.net>2023-06-08 16:43:00 +0300
commita1b6f13578e15e09fdaee5d90f05de04b59240bd (patch)
treeb89fcf16d0912d1437d1c908edf544ac47d55aec /drivers/hwmon
parentca866920b0f35350b8b2bf9c7323051649a75bee (diff)
downloadlinux-a1b6f13578e15e09fdaee5d90f05de04b59240bd.tar.xz
hwmon: (pmbus/adm1266) Drop unnecessary error check for debugfs_create_dir
This patch removes the error checking for debugfs_create_dir in adm1266.c. This is because the debugfs_create_dir() does not return NULL but an ERR_PTR after an error. The DebugFS kernel API is developed in a way that the caller can safely ignore the errors that occur during the creation of DebugFS nodes.The debugfs Api handles it gracefully. The check is unnecessary. Link to the comment above debugfs_create_dir: https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L565 Signed-off-by: Osama Muhammad <osmtendev@gmail.com> Link: https://lore.kernel.org/r/20230526163938.9903-1-osmtendev@gmail.com Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
-rw-r--r--drivers/hwmon/pmbus/adm1266.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/hwmon/pmbus/adm1266.c b/drivers/hwmon/pmbus/adm1266.c
index aba70330b319..ed0a7b9fae4b 100644
--- a/drivers/hwmon/pmbus/adm1266.c
+++ b/drivers/hwmon/pmbus/adm1266.c
@@ -340,8 +340,6 @@ static void adm1266_init_debugfs(struct adm1266_data *data)
return;
data->debugfs_dir = debugfs_create_dir(data->client->name, root);
- if (!data->debugfs_dir)
- return;
debugfs_create_devm_seqfile(&data->client->dev, "sequencer_state", data->debugfs_dir,
adm1266_state_read);