diff options
author | Jaco Kroon <jaco@uls.co.za> | 2023-05-17 11:00:03 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2023-05-17 15:03:45 +0300 |
commit | 96ba44c637b0d30535374f328186a370accab208 (patch) | |
tree | 74139772d489f19df2b43f91dc00d04de572f4be /drivers/hwspinlock | |
parent | c83ae452d2644f921985a6d8a2f4affeded570dd (diff) | |
download | linux-96ba44c637b0d30535374f328186a370accab208.tar.xz |
net/pppoe: make number of hash bits configurable
When running large numbers of pppoe connections, a bucket size of 16 may
be too small and 256 may be more appropriate. This sacrifices some RAM
but should result in faster processing of incoming PPPoE frames.
On our systems we run upwards of 150 PPPoE connections at any point in
time, and we suspect we're starting to see the effects of this small
number of buckets.
The legal values according to pppoe.c is anything that when 8 is divided
by that results in a modulo of 0, ie, 1, 2, 4 and 8.
The size of the per-underlying-interface structure is:
sizeof(rwlock_t) + sizeof(pppox_sock*) * PPPOE_HASH_SIZE.
Assuming a 64-bit pointer this will result in just over a 2KiB structure
for PPPOE_HASH_BITS=8, which will likely result in a 4KiB allocation,
which for us at least is acceptable.
Not sure what the minimum allocation size is, and thus if values of 1
and 2 truly make sense. Default results in historic sizing and
behaviour.
Signed-off-by: Jaco Kroon <jaco@uls.co.za>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/hwspinlock')
0 files changed, 0 insertions, 0 deletions