diff options
| author | Yann Sionneau <yann@sionneau.net> | 2023-08-25 17:32:34 +0300 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2023-08-30 22:19:55 +0300 |
| commit | 0ab4bcf0e9471c1a3f5e4721ee486f6ed1a76bac (patch) | |
| tree | 8ef9715d68d2838f7bb241d547781ef2dca271dc /drivers/i2c | |
| parent | e23e610058acd7b2b9339407e102976a2144e524 (diff) | |
| download | linux-0ab4bcf0e9471c1a3f5e4721ee486f6ed1a76bac.tar.xz | |
i2c: at91: Use dev_err_probe() instead of dev_err()
Change
if (IS_ERR(x)) { dev_err(...); return PTR_ERR(x); }
into
return dev_err_probe()
Also, return the correct error instead of hardcoding -ENODEV
This change has also the advantage of handling the -EPROBE_DEFER situation.
Signed-off-by: Yann Sionneau <yann@sionneau.net>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c')
| -rw-r--r-- | drivers/i2c/busses/i2c-at91-core.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c index 91d66ec14588..db45554327ae 100644 --- a/drivers/i2c/busses/i2c-at91-core.c +++ b/drivers/i2c/busses/i2c-at91-core.c @@ -222,10 +222,9 @@ static int at91_twi_probe(struct platform_device *pdev) platform_set_drvdata(pdev, dev); dev->clk = devm_clk_get(dev->dev, NULL); - if (IS_ERR(dev->clk)) { - dev_err(dev->dev, "no clock defined\n"); - return -ENODEV; - } + if (IS_ERR(dev->clk)) + return dev_err_probe(dev->dev, PTR_ERR(dev->clk), "no clock defined\n"); + clk_prepare_enable(dev->clk); snprintf(dev->adapter.name, sizeof(dev->adapter.name), "AT91"); |