diff options
| author | Bryan Tan <bryantan@vmware.com> | 2023-06-05 21:37:28 +0300 |
|---|---|---|
| committer | Jason Gunthorpe <jgg@nvidia.com> | 2023-06-09 20:11:53 +0300 |
| commit | 7ad697cdd31b9d5e59e25b035bad4cdd8e76aca1 (patch) | |
| tree | 35d6a08e4a581be9a9fd9e5cc892390099a6df49 /drivers/infiniband/hw/vmw_pvrdma | |
| parent | c3e1bf626eb3c53ea60a0c64b441fb3015e1652e (diff) | |
| download | linux-7ad697cdd31b9d5e59e25b035bad4cdd8e76aca1.tar.xz | |
RDMA/vmw_pvrdma: Remove unnecessary check on wr->opcode
wr->opcode is unsigned; checking if it is negative is unnecessary. Fix
this issue by removing the check.
Fixes: 29c8d9eba550 ("IB: Add vmw_pvrdma driver")
Link: https://lore.kernel.org/r/20230605183728.47021-1-bryantan@vmware.com
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/07c48eee-0aca-48ee-897a-38588c341c41@kili.mountain
Signed-off-by: Bryan Tan <bryantan@vmware.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Diffstat (limited to 'drivers/infiniband/hw/vmw_pvrdma')
| -rw-r--r-- | drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c index f83cd4a9d992..98b2a0090bf2 100644 --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c @@ -709,14 +709,6 @@ int pvrdma_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr, goto out; } - if (unlikely(wr->opcode < 0)) { - dev_warn_ratelimited(&dev->pdev->dev, - "invalid send opcode\n"); - *bad_wr = wr; - ret = -EINVAL; - goto out; - } - /* * Only support UD, RC. * Need to check opcode table for thorough checking. |