summaryrefslogtreecommitdiff
path: root/drivers/input/rmi4
diff options
context:
space:
mode:
authorStephan Gerhold <stephan@gerhold.net>2020-01-18 00:40:36 +0300
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2020-01-21 07:40:04 +0300
commit996d5d5f89a558a3608a46e73ccd1b99f1b1d058 (patch)
tree9e17275b03fc5c10f76cbcc89eb867131f00e921 /drivers/input/rmi4
parentba9a103f40fc4a3ec7558ec9b0b97d4f92034249 (diff)
downloadlinux-996d5d5f89a558a3608a46e73ccd1b99f1b1d058.tar.xz
Input: pm8xxx-vib - fix handling of separate enable register
Setting the vibrator enable_mask is not implemented correctly: For regmap_update_bits(map, reg, mask, val) we give in either regs->enable_mask or 0 (= no-op) as mask and "val" as value. But "val" actually refers to the vibrator voltage control register, which has nothing to do with the enable_mask. So we usually end up doing nothing when we really wanted to enable the vibrator. We want to set or clear the enable_mask (to enable/disable the vibrator). Therefore, change the call to always modify the enable_mask and set the bits only if we want to enable the vibrator. Fixes: d4c7c5c96c92 ("Input: pm8xxx-vib - handle separate enable register") Signed-off-by: Stephan Gerhold <stephan@gerhold.net> Link: https://lore.kernel.org/r/20200114183442.45720-1-stephan@gerhold.net Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/rmi4')
0 files changed, 0 insertions, 0 deletions