summaryrefslogtreecommitdiff
path: root/drivers/irqchip/irq-eznps.c
diff options
context:
space:
mode:
authorNoam Camus <noamca@mellanox.com>2016-10-13 16:15:32 +0300
committerThomas Gleixner <tglx@linutronix.de>2016-10-14 15:26:54 +0300
commitc0ca8df717061ae3d2ea624024033103c64210ae (patch)
treea4ddb3bab92356267a398fa16ff6d9d9f2f6f3a8 /drivers/irqchip/irq-eznps.c
parent65543b3353e7d29d258aac4190cda6a2f49abeb3 (diff)
downloadlinux-c0ca8df717061ae3d2ea624024033103c64210ae.tar.xz
irqchip/eznps: Acknowledge NPS_IPI before calling the handler
IPI_IRQ (also TIMER0_IRQ) should be acked before the action->handler is called in handle_percpu_devid_irq. The IPI irq is edge sensitive and we might miss an IPI interrupt if it is triggered again while the handler runs. Fixes: 44df427c894a ("irqchip: add nps Internal and external irqchips") Signed-off-by: Noam Camus <noamca@mellanox.com> Cc: marc.zyngier@arm.com Cc: jason@lakedaemon.net Cc: stable@vger.kernel.org Link: http://lkml.kernel.org/r/1476364532-12634-1-git-send-email-noamca@mellanox.com Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'drivers/irqchip/irq-eznps.c')
-rw-r--r--drivers/irqchip/irq-eznps.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/irqchip/irq-eznps.c b/drivers/irqchip/irq-eznps.c
index efbf0e4304b7..ebc2b0b15f67 100644
--- a/drivers/irqchip/irq-eznps.c
+++ b/drivers/irqchip/irq-eznps.c
@@ -85,7 +85,7 @@ static void nps400_irq_eoi_global(struct irq_data *irqd)
nps_ack_gic();
}
-static void nps400_irq_eoi(struct irq_data *irqd)
+static void nps400_irq_ack(struct irq_data *irqd)
{
unsigned int __maybe_unused irq = irqd_to_hwirq(irqd);
@@ -103,7 +103,7 @@ static struct irq_chip nps400_irq_chip_percpu = {
.name = "NPS400 IC",
.irq_mask = nps400_irq_mask,
.irq_unmask = nps400_irq_unmask,
- .irq_eoi = nps400_irq_eoi,
+ .irq_ack = nps400_irq_ack,
};
static int nps400_irq_map(struct irq_domain *d, unsigned int virq,