summaryrefslogtreecommitdiff
path: root/drivers/isdn/mISDN
diff options
context:
space:
mode:
authorJakub Kicinski <kuba@kernel.org>2022-09-28 21:12:36 +0300
committerJakub Kicinski <kuba@kernel.org>2022-09-30 05:27:17 +0300
commit6ad1c94e1e7e374d88f0cfd77936dddb8339aaba (patch)
tree6d0b763d1dad3cfc4f044f88a5c3c0e2be30c134 /drivers/isdn/mISDN
parent0e3f72931fc47bb81686020cc643cde5d9cd0bb8 (diff)
downloadlinux-6ad1c94e1e7e374d88f0cfd77936dddb8339aaba.tar.xz
eth: alx: take rtnl_lock on resume
Zbynek reports that alx trips an rtnl assertion on resume: RTNL: assertion failed at net/core/dev.c (2891) RIP: 0010:netif_set_real_num_tx_queues+0x1ac/0x1c0 Call Trace: <TASK> __alx_open+0x230/0x570 [alx] alx_resume+0x54/0x80 [alx] ? pci_legacy_resume+0x80/0x80 dpm_run_callback+0x4a/0x150 device_resume+0x8b/0x190 async_resume+0x19/0x30 async_run_entry_fn+0x30/0x130 process_one_work+0x1e5/0x3b0 indeed the driver does not hold rtnl_lock during its internal close and re-open functions during suspend/resume. Note that this is not a huge bug as the driver implements its own locking, and does not implement changing the number of queues, but we need to silence the splat. Fixes: 4a5fe57e7751 ("alx: use fine-grained locking instead of RTNL") Reported-and-tested-by: Zbynek Michl <zbynek.michl@gmail.com> Reviewed-by: Niels Dossche <dossche.niels@gmail.com> Link: https://lore.kernel.org/r/20220928181236.1053043-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/isdn/mISDN')
0 files changed, 0 insertions, 0 deletions