summaryrefslogtreecommitdiff
path: root/drivers/media/radio
diff options
context:
space:
mode:
authorChuhong Yuan <hslester96@gmail.com>2019-11-10 09:28:15 +0300
committerMauro Carvalho Chehab <mchehab@kernel.org>2019-11-10 09:28:15 +0300
commit2df200ab234a86836a8879a05a8007d6b884eb14 (patch)
treec0257d1d8c344d51a7842f214dd1382ea2e227d0 /drivers/media/radio
parent4ffd31463ce303de92724d4e1faf7807f68a4aa5 (diff)
downloadlinux-2df200ab234a86836a8879a05a8007d6b884eb14.tar.xz
media: si470x-i2c: add missed operations in remove
The driver misses calling v4l2_ctrl_handler_free and v4l2_device_unregister in remove like what is done in probe failure. Add the calls to fix it. Signed-off-by: Chuhong Yuan <hslester96@gmail.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/media/radio')
-rw-r--r--drivers/media/radio/si470x/radio-si470x-i2c.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c b/drivers/media/radio/si470x/radio-si470x-i2c.c
index 7541698a0be1..f491420d7b53 100644
--- a/drivers/media/radio/si470x/radio-si470x-i2c.c
+++ b/drivers/media/radio/si470x/radio-si470x-i2c.c
@@ -482,6 +482,8 @@ static int si470x_i2c_remove(struct i2c_client *client)
if (radio->gpio_reset)
gpiod_set_value(radio->gpio_reset, 0);
+ v4l2_ctrl_handler_free(&radio->hdl);
+ v4l2_device_unregister(&radio->v4l2_dev);
return 0;
}