summaryrefslogtreecommitdiff
path: root/drivers/memory
diff options
context:
space:
mode:
authorLiang He <windhl@126.com>2022-07-16 06:13:24 +0300
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>2022-08-16 12:12:03 +0300
commit61b3c876c1cbdb1efd1f52a1f348580e6e14efb6 (patch)
tree99f05ae203a74fca9a682fb45b3c3921c46bde41 /drivers/memory
parent568035b01cfb107af8d2e4bd2fb9aea22cf5b868 (diff)
downloadlinux-61b3c876c1cbdb1efd1f52a1f348580e6e14efb6.tar.xz
memory: pl353-smc: Fix refcount leak bug in pl353_smc_probe()
The break of for_each_available_child_of_node() needs a corresponding of_node_put() when the reference 'child' is not used anymore. Here we do not need to call of_node_put() in fail path as '!match' means no break. While the of_platform_device_create() will created a new reference by 'child' but it has considered the refcounting. Fixes: fee10bd22678 ("memory: pl353: Add driver for arm pl353 static memory controller") Signed-off-by: Liang He <windhl@126.com> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://lore.kernel.org/r/20220716031324.447680-1-windhl@126.com
Diffstat (limited to 'drivers/memory')
-rw-r--r--drivers/memory/pl353-smc.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/memory/pl353-smc.c b/drivers/memory/pl353-smc.c
index f84b98278745..d39ee7d06665 100644
--- a/drivers/memory/pl353-smc.c
+++ b/drivers/memory/pl353-smc.c
@@ -122,6 +122,7 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
}
of_platform_device_create(child, NULL, &adev->dev);
+ of_node_put(child);
return 0;