summaryrefslogtreecommitdiff
path: root/drivers/mfd/wm8350-core.c
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2014-10-27 08:25:02 +0300
committerLee Jones <lee.jones@linaro.org>2014-11-25 19:18:51 +0300
commit1753b40f5c97e0d0bf2f0a562603cfc592945a5e (patch)
tree5a6201cef20d0a3e1252575360578231cdcf3e50 /drivers/mfd/wm8350-core.c
parent7d082baa349e59ce3de6452abc05e5de6436aad4 (diff)
downloadlinux-1753b40f5c97e0d0bf2f0a562603cfc592945a5e.tar.xz
mfd: wm8350-core: Fix probable mask then right shift defect
Precedence of & and >> is not the same and is not left to right. shift has higher precedence and should be done after the mask. Add parentheses around the mask. Signed-off-by: Joe Perches <joe@perches.com> Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd/wm8350-core.c')
-rw-r--r--drivers/mfd/wm8350-core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
index 4ab527f5c53b..f5124a8acad8 100644
--- a/drivers/mfd/wm8350-core.c
+++ b/drivers/mfd/wm8350-core.c
@@ -308,7 +308,7 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq,
goto err;
}
- mode = id2 & WM8350_CONF_STS_MASK >> 10;
+ mode = (id2 & WM8350_CONF_STS_MASK) >> 10;
cust_id = id2 & WM8350_CUST_ID_MASK;
chip_rev = (id2 & WM8350_CHIP_REV_MASK) >> 12;
dev_info(wm8350->dev,