summaryrefslogtreecommitdiff
path: root/drivers/mfd
diff options
context:
space:
mode:
authorSergey Larin <cerg2010cerg2010@mail.ru>2021-06-15 01:24:20 +0300
committerLee Jones <lee.jones@linaro.org>2021-06-15 15:18:58 +0300
commit184b69c5d3a7ec778b370ba00c05174d365bcc18 (patch)
tree5443a8f613b6812a5e0b73fec4888ebbf3b60594 /drivers/mfd
parentafb349c09601fbf1b0f4d9fc6360d1181ba2ed4f (diff)
downloadlinux-184b69c5d3a7ec778b370ba00c05174d365bcc18.tar.xz
mfd: max8907: Remove IRQF_NO_AUTOEN flag
IRQF_NO_AUTOEN flag doesn't go well with IRQF_SHARED flag - the check in request_threaded_irq fails and exits with EINVAL. So we ignore the flag and enable it on the first IRQ request. No interrupt should arrive from the chip as all interrupts are masked by default. Signed-off-by: Sergey Larin <cerg2010cerg2010@mail.ru> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/mfd')
-rw-r--r--drivers/mfd/max8907.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c
index 40e70ab88956..41f566e6a096 100644
--- a/drivers/mfd/max8907.c
+++ b/drivers/mfd/max8907.c
@@ -229,7 +229,7 @@ static int max8907_i2c_probe(struct i2c_client *i2c,
}
ret = regmap_add_irq_chip(max8907->regmap_gen, max8907->i2c_gen->irq,
- IRQF_ONESHOT | IRQF_SHARED | IRQF_NO_AUTOEN,
+ IRQF_ONESHOT | IRQF_SHARED,
-1, &max8907_chg_irq_chip,
&max8907->irqc_chg);
if (ret != 0) {
@@ -253,8 +253,6 @@ static int max8907_i2c_probe(struct i2c_client *i2c,
goto err_irqc_rtc;
}
- enable_irq(max8907->i2c_gen->irq);
-
ret = mfd_add_devices(max8907->dev, -1, max8907_cells,
ARRAY_SIZE(max8907_cells), NULL, 0, NULL);
if (ret != 0) {