summaryrefslogtreecommitdiff
path: root/drivers/misc/echo
diff options
context:
space:
mode:
authorNathan Chancellor <natechancellor@gmail.com>2018-09-15 09:43:37 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-09-25 21:21:02 +0300
commit85dc2c65e6c975baaf36ea30f2ccc0a36a8c8add (patch)
tree24cdc8f800f3488b29f975a9f96f2c88ec94a329 /drivers/misc/echo
parent9e663f4811c6fd58c03e918c3f0a2e08810e38c1 (diff)
downloadlinux-85dc2c65e6c975baaf36ea30f2ccc0a36a8c8add.tar.xz
misc: echo: Remove unnecessary parentheses and simplify check for zero
Clang warns when multiple pairs of parentheses are used for a single conditional statement. drivers/misc/echo/echo.c:384:27: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((ec->nonupdate_dwell == 0)) { ~~~~~~~~~~~~~~~~~~~~^~~~ drivers/misc/echo/echo.c:384:27: note: remove extraneous parentheses around the comparison to silence this warning if ((ec->nonupdate_dwell == 0)) { ~ ^ ~ drivers/misc/echo/echo.c:384:27: note: use '=' to turn this equality comparison into an assignment if ((ec->nonupdate_dwell == 0)) { ^~ = 1 warning generated. Remove them and while we're at it, simplify the zero check as '!var' is used more than 'var == 0'. Reported-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/echo')
-rw-r--r--drivers/misc/echo/echo.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/echo/echo.c b/drivers/misc/echo/echo.c
index 8a5adc0d2e88..3ebe5d75ad6a 100644
--- a/drivers/misc/echo/echo.c
+++ b/drivers/misc/echo/echo.c
@@ -381,7 +381,7 @@ int16_t oslec_update(struct oslec_state *ec, int16_t tx, int16_t rx)
*/
ec->factor = 0;
ec->shift = 0;
- if ((ec->nonupdate_dwell == 0)) {
+ if (!ec->nonupdate_dwell) {
int p, logp, shift;
/* Determine: