summaryrefslogtreecommitdiff
path: root/drivers/net/amt.c
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2022-08-18 12:31:14 +0300
committerJakub Kicinski <kuba@kernel.org>2022-08-20 02:51:21 +0300
commit6745bc9b0351525e80cc7578e8ce22f83cfa3a84 (patch)
tree207760134ae707a6c77f8c373ea300d175c355e8 /drivers/net/amt.c
parentb690842d12fd6687c326663d69d5732de00c00f6 (diff)
downloadlinux-6745bc9b0351525e80cc7578e8ce22f83cfa3a84.tar.xz
amt: remove unnecessary skb pointer check
The skb pointer will be checked in kfree_skb(), so remove the outside check. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Taehee Yoo <ap420073@gmail.com> Link: https://lore.kernel.org/r/20220818093114.2449179-1-yangyingliang@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/amt.c')
-rw-r--r--drivers/net/amt.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/amt.c b/drivers/net/amt.c
index 9a247eb7679c..2d20be6ffb7e 100644
--- a/drivers/net/amt.c
+++ b/drivers/net/amt.c
@@ -2894,8 +2894,7 @@ static void amt_event_work(struct work_struct *work)
amt_event_send_request(amt);
break;
default:
- if (skb)
- kfree_skb(skb);
+ kfree_skb(skb);
break;
}
}
@@ -3033,8 +3032,7 @@ static int amt_dev_stop(struct net_device *dev)
cancel_work_sync(&amt->event_wq);
for (i = 0; i < AMT_MAX_EVENTS; i++) {
skb = amt->events[i].skb;
- if (skb)
- kfree_skb(skb);
+ kfree_skb(skb);
amt->events[i].event = AMT_EVENT_NONE;
amt->events[i].skb = NULL;
}