diff options
| author | Peng Wu <wupeng58@huawei.com> | 2022-06-28 16:09:20 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-06-30 06:57:11 +0300 |
| commit | 626af58bad5817af442d992f9966a7bf793f1562 (patch) | |
| tree | 3eba80978be5eb0bb17adfcb0bbd4bc33de292a9 /drivers/net/dsa | |
| parent | 3ce7547e5b710cb90e1150f9bb867c133576441a (diff) | |
| download | linux-626af58bad5817af442d992f9966a7bf793f1562.tar.xz | |
net: dsa: rzn1-a5psw: fix a NULL vs IS_ERR() check in a5psw_probe()
The devm_platform_ioremap_resource() function never returns NULL.
It returns error pointers.
Signed-off-by: Peng Wu <wupeng58@huawei.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Clément Léger <clement.leger@bootlin.com>
Link: https://lore.kernel.org/r/20220628130920.49493-1-wupeng58@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/dsa')
| -rw-r--r-- | drivers/net/dsa/rzn1_a5psw.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c index 3e910da98ae2..5b14e2ba9b79 100644 --- a/drivers/net/dsa/rzn1_a5psw.c +++ b/drivers/net/dsa/rzn1_a5psw.c @@ -946,8 +946,8 @@ static int a5psw_probe(struct platform_device *pdev) mutex_init(&a5psw->lk_lock); spin_lock_init(&a5psw->reg_lock); a5psw->base = devm_platform_ioremap_resource(pdev, 0); - if (!a5psw->base) - return -EINVAL; + if (IS_ERR(a5psw->base)) + return PTR_ERR(a5psw->base); ret = a5psw_pcs_get(a5psw); if (ret) |