diff options
author | Tom Rix <trix@redhat.com> | 2020-08-21 16:56:00 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-08-26 11:29:59 +0300 |
commit | b5ce9e60c76f0be5d743605f68f9438c641d015e (patch) | |
tree | b10bfe8d580ad0cb31c77e26e17ac04313519c3a /drivers/net/ethernet/8390/wd.c | |
parent | 30cb922fdc59f81403a9ce9fdbc277be0d9da3ee (diff) | |
download | linux-b5ce9e60c76f0be5d743605f68f9438c641d015e.tar.xz |
net: dsa: b53: check for timeout
[ Upstream commit 774d977abfd024e6f73484544b9abe5a5cd62de7 ]
clang static analysis reports this problem
b53_common.c:1583:13: warning: The left expression of the compound
assignment is an uninitialized value. The computed value will
also be garbage
ent.port &= ~BIT(port);
~~~~~~~~ ^
ent is set by a successful call to b53_arl_read(). Unsuccessful
calls are caught by an switch statement handling specific returns.
b32_arl_read() calls b53_arl_op_wait() which fails with the
unhandled -ETIMEDOUT.
So add -ETIMEDOUT to the switch statement. Because
b53_arl_op_wait() already prints out a message, do not add another
one.
Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations")
Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/8390/wd.c')
0 files changed, 0 insertions, 0 deletions