diff options
| author | Pavan Kumar Linga <pavan.kumar.linga@intel.com> | 2023-10-23 23:26:55 +0300 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2023-10-24 01:55:31 +0300 |
| commit | 46d913d4800e5b02fa20683785d873404f1667c4 (patch) | |
| tree | 53420a8f72766c04476d169acd88e60cf457c3a3 /drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | |
| parent | d38b4d0d95bc0c7243ca54a32c256c0583b6a9fc (diff) | |
| download | linux-46d913d4800e5b02fa20683785d873404f1667c4.tar.xz | |
idpf: cancel mailbox work in error path
In idpf_vc_core_init, the mailbox work is queued
on a mailbox workqueue but it is not cancelled on error.
This results in a call trace when idpf_mbx_task tries
to access the freed mailbox queue pointer. Fix it by
cancelling the mailbox work in the error path.
Fixes: 4930fbf419a7 ("idpf: add core init and interrupt request")
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20231023202655.173369-3-jacob.e.keller@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/intel/idpf/idpf_virtchnl.c')
| -rw-r--r-- | drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c index e276b5360c2e..2c1b051fdc0d 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -3146,6 +3146,7 @@ restart: err_intr_req: cancel_delayed_work_sync(&adapter->serv_task); + cancel_delayed_work_sync(&adapter->mbx_task); idpf_vport_params_buf_rel(adapter); err_netdev_alloc: kfree(adapter->vports); |