diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2020-04-26 23:59:21 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-05-20 09:17:05 +0300 |
| commit | ddbc1ac2fdbece54d84b5f5c6bb4296d6b0f5e09 (patch) | |
| tree | 8f2db2d95fb1ce9c66c3c2822520b7ce14a40ce5 /drivers/net/ethernet/moxa | |
| parent | 2216157f8ef664170e4fe251716b782953c14885 (diff) | |
| download | linux-ddbc1ac2fdbece54d84b5f5c6bb4296d6b0f5e09.tar.xz | |
net: moxa: Fix a potential double 'free_irq()'
[ Upstream commit ee8d2267f0e39a1bfd95532da3a6405004114b27 ]
Should an irq requested with 'devm_request_irq' be released explicitly,
it should be done by 'devm_free_irq()', not 'free_irq()'.
Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/moxa')
| -rw-r--r-- | drivers/net/ethernet/moxa/moxart_ether.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c index 2e4effa9fe45..beb730ff5d42 100644 --- a/drivers/net/ethernet/moxa/moxart_ether.c +++ b/drivers/net/ethernet/moxa/moxart_ether.c @@ -561,7 +561,7 @@ static int moxart_remove(struct platform_device *pdev) struct net_device *ndev = platform_get_drvdata(pdev); unregister_netdev(ndev); - free_irq(ndev->irq, ndev); + devm_free_irq(&pdev->dev, ndev->irq, ndev); moxart_mac_free_memory(ndev); free_netdev(ndev); |