summaryrefslogtreecommitdiff
path: root/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
diff options
context:
space:
mode:
authorChengfeng Ye <dg573847474@gmail.com>2023-12-07 15:34:53 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-12-20 19:00:16 +0300
commit7cfbb8bea36ad184bc5e9bd4ef028805dcff8370 (patch)
treea8c8fb58ddb32786cb747c86a03e15462248fb46 /drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
parent35c63d366fff4e930a7c44f25a8a184e0189e74a (diff)
downloadlinux-7cfbb8bea36ad184bc5e9bd4ef028805dcff8370.tar.xz
atm: solos-pci: Fix potential deadlock on &tx_queue_lock
[ Upstream commit 15319a4e8ee4b098118591c6ccbd17237f841613 ] As &card->tx_queue_lock is acquired under softirq context along the following call chain from solos_bh(), other acquisition of the same lock inside process context should disable at least bh to avoid double lock. <deadlock #2> pclose() --> spin_lock(&card->tx_queue_lock) <interrupt> --> solos_bh() --> fpga_tx() --> spin_lock(&card->tx_queue_lock) This flaw was found by an experimental static analysis tool I am developing for irq-related deadlock. To prevent the potential deadlock, the patch uses spin_lock_bh() on &card->tx_queue_lock under process context code consistently to prevent the possible deadlock scenario. Fixes: 213e85d38912 ("solos-pci: clean up pclose() function") Signed-off-by: Chengfeng Ye <dg573847474@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c')
0 files changed, 0 insertions, 0 deletions