summaryrefslogtreecommitdiff
path: root/drivers/net/ppp/pppoe.c
diff options
context:
space:
mode:
authorGuillaume Nault <g.nault@alphalink.fr>2016-02-15 19:01:10 +0300
committerDavid S. Miller <davem@davemloft.net>2016-02-18 00:02:01 +0300
commit29e73269aa4d36f92b35610c25f8b01c789b0dc8 (patch)
tree72e7e31f35955e50b53c4051a2250cd96bbaf459 /drivers/net/ppp/pppoe.c
parent705bcdda81eda8b4b4c564c4be7b8cfad6a180d6 (diff)
downloadlinux-29e73269aa4d36f92b35610c25f8b01c789b0dc8.tar.xz
pppoe: fix reference counting in PPPoE proxy
Drop reference on the relay_po socket when __pppoe_xmit() succeeds. This is already handled correctly in the error path. Signed-off-by: Guillaume Nault <g.nault@alphalink.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ppp/pppoe.c')
-rw-r--r--drivers/net/ppp/pppoe.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index f3c63022eb3c..4ddae8118c85 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -395,6 +395,8 @@ static int pppoe_rcv_core(struct sock *sk, struct sk_buff *skb)
if (!__pppoe_xmit(sk_pppox(relay_po), skb))
goto abort_put;
+
+ sock_put(sk_pppox(relay_po));
} else {
if (sock_queue_rcv_skb(sk, skb))
goto abort_kfree;