summaryrefslogtreecommitdiff
path: root/drivers/net/wan/lmc
diff options
context:
space:
mode:
authorJulia Lawall <julia.lawall@lip6.fr>2015-04-05 15:06:21 +0300
committerDavid S. Miller <davem@davemloft.net>2015-04-07 22:21:54 +0300
commit27d751bfa41bdc022d1357479ff67c6902c02c8c (patch)
tree8308ab4507f425d3c34b1298f6aab20c5bc1d8fe /drivers/net/wan/lmc
parent7abccdba25be45630eede85053496f1f48d36ec8 (diff)
downloadlinux-27d751bfa41bdc022d1357479ff67c6902c02c8c.tar.xz
wan: lmc: fix error return code
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/wan/lmc')
-rw-r--r--drivers/net/wan/lmc/lmc_main.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
index bea0f313a7a8..317bc79cc8b9 100644
--- a/drivers/net/wan/lmc/lmc_main.c
+++ b/drivers/net/wan/lmc/lmc_main.c
@@ -850,6 +850,7 @@ static int lmc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
dev = alloc_hdlcdev(sc);
if (!dev) {
printk(KERN_ERR "lmc:alloc_netdev for device failed\n");
+ err = -ENOMEM;
goto err_hdlcdev;
}