diff options
author | Felix Fietkau <nbd@nbd.name> | 2019-07-01 14:15:07 +0300 |
---|---|---|
committer | Felix Fietkau <nbd@nbd.name> | 2019-09-05 18:42:27 +0300 |
commit | 850e8f6fbd5d0003b0f1119d19a01c6fef1644e2 (patch) | |
tree | b6660812f06aabdab6b66d81954fe0984b5c42c5 /drivers/net/wireless/mediatek/mt76/usb.c | |
parent | 84b0b66352470e6491c06159735ac916dc69a2ef (diff) | |
download | linux-850e8f6fbd5d0003b0f1119d19a01c6fef1644e2.tar.xz |
mt76: round up length on mt76_wr_copy
When beacon length is not a multiple of 4, the beacon could be sent with
the last 1-3 bytes corrupted. The skb data is guaranteed to have enough
room for reading beyond the end, because it is always followed by
skb_shared_info, so rounding up is safe.
All other callers of mt76_wr_copy have multiple-of-4 length already.
Cc: stable@vger.kernel.org
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Diffstat (limited to 'drivers/net/wireless/mediatek/mt76/usb.c')
-rw-r--r-- | drivers/net/wireless/mediatek/mt76/usb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wireless/mediatek/mt76/usb.c index fb87ce7fbdf6..185eea83aada 100644 --- a/drivers/net/wireless/mediatek/mt76/usb.c +++ b/drivers/net/wireless/mediatek/mt76/usb.c @@ -164,7 +164,7 @@ static void mt76u_copy(struct mt76_dev *dev, u32 offset, int i, ret; mutex_lock(&usb->usb_ctrl_mtx); - for (i = 0; i < (len / 4); i++) { + for (i = 0; i < DIV_ROUND_UP(len, 4); i++) { put_unaligned_le32(val[i], usb->data); ret = __mt76u_vendor_request(dev, MT_VEND_MULTI_WRITE, USB_DIR_OUT | USB_TYPE_VENDOR, |