diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2019-09-25 14:01:00 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-01-27 16:51:15 +0300 |
commit | aa08e30cb7c481ced2ae7ea04441358fa71cd807 (patch) | |
tree | 497729ef9bde9ea3c535df50cbf8c80f661462d4 /drivers/of | |
parent | bb8179ad7662fd44ddb9c721dbf3007aaa05f16f (diff) | |
download | linux-aa08e30cb7c481ced2ae7ea04441358fa71cd807.tar.xz |
of: mdio: Fix a signedness bug in of_phy_get_and_connect()
[ Upstream commit d7eb651212fdbafa82d485d8e76095ac3b14c193 ]
The "iface" variable is an enum and in this context GCC treats it as
an unsigned int so the error handling is never triggered.
Fixes: b78624125304 ("of_mdio: Abstract a general interface for phy connect")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/of')
-rw-r--r-- | drivers/of/of_mdio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index 5ad1342f5682..7d2bc22680d9 100644 --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -370,7 +370,7 @@ struct phy_device *of_phy_get_and_connect(struct net_device *dev, int ret; iface = of_get_phy_mode(np); - if (iface < 0) + if ((int)iface < 0) return NULL; if (of_phy_is_fixed_link(np)) { ret = of_phy_register_fixed_link(np); |