summaryrefslogtreecommitdiff
path: root/drivers/opp
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2022-04-06 09:40:14 +0300
committerViresh Kumar <viresh.kumar@linaro.org>2022-04-11 05:50:27 +0300
commit907ed123b9d096c73e9361f6cd4097f0691497f2 (patch)
tree1d82359b178f2c6912caa9bfd0f69ed1ba93c1d9 /drivers/opp
parent3123109284176b1532874591f7c81f3837bbdc17 (diff)
downloadlinux-907ed123b9d096c73e9361f6cd4097f0691497f2.tar.xz
OPP: call of_node_put() on error path in _bandwidth_supported()
This code does not call of_node_put(opp_np) if of_get_next_available_child() returns NULL. But it should. Fixes: 45679f9b508f ("opp: Don't parse icc paths unnecessarily") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Diffstat (limited to 'drivers/opp')
-rw-r--r--drivers/opp/of.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index 440ab5a03df9..95b184fc3372 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -437,11 +437,11 @@ static int _bandwidth_supported(struct device *dev, struct opp_table *opp_table)
/* Checking only first OPP is sufficient */
np = of_get_next_available_child(opp_np, NULL);
+ of_node_put(opp_np);
if (!np) {
dev_err(dev, "OPP table empty\n");
return -EINVAL;
}
- of_node_put(opp_np);
prop = of_find_property(np, "opp-peak-kBps", NULL);
of_node_put(np);