summaryrefslogtreecommitdiff
path: root/drivers/perf/thunderx2_pmu.c
diff options
context:
space:
mode:
authorThomas Gleixner <tglx@linutronix.de>2021-05-18 12:17:32 +0300
committerWill Deacon <will@kernel.org>2021-05-24 13:02:00 +0300
commitba4489fb949cbd9c9b877dceae361129ed6280f1 (patch)
tree05929c962cc093f8236d511d130704449a6032ca /drivers/perf/thunderx2_pmu.c
parent2621054535955fb78ea96b76b279eb481f40fcef (diff)
downloadlinux-ba4489fb949cbd9c9b877dceae361129ed6280f1.tar.xz
perf/imx_ddr: Use irq_set_affinity()
The driver uses irq_set_affinity_hint() to set the affinity for the PMU interrupts, which relies on the undocumented side effect that this function actually sets the affinity under the hood. Setting an hint is clearly not a guarantee and for these PMU interrupts an affinity hint, which is supposed to guide userspace for setting affinity, is beyond pointless, because the affinity of these interrupts cannot be modified from user space. Aside of that the error checks are bogus because the only error which is returned from irq_set_affinity_hint() is when there is no irq descriptor for the interrupt number, but not when the affinity set fails. That's on purpose because the hint can point to an offline CPU. Replace the mindless abuse with irq_set_affinity(). Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Frank Li <Frank.li@nxp.com> Cc: Will Deacon <will@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: NXP Linux Team <linux-imx@nxp.com> Cc: linux-arm-kernel@lists.infradead.org Acked-by: Mark Rutland <mark.rutland@arm.com> Link: https://lore.kernel.org/r/20210518093118.699566062@linutronix.de Signed-off-by: Will Deacon <will@kernel.org>
Diffstat (limited to 'drivers/perf/thunderx2_pmu.c')
0 files changed, 0 insertions, 0 deletions