summaryrefslogtreecommitdiff
path: root/drivers/phy/microchip
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2021-09-09 10:21:49 +0300
committerVinod Koul <vkoul@kernel.org>2021-10-26 14:06:23 +0300
commitb4dc97ab0a629eda8bda20d96ef47dac08a505d9 (patch)
tree8ead89c12513b22e7672c72322d66a04cca07f5a /drivers/phy/microchip
parentb475bf0ec40a2b13fb32ef62f5706576d5858460 (diff)
downloadlinux-b4dc97ab0a629eda8bda20d96ef47dac08a505d9.tar.xz
phy: Sparx5 Eth SerDes: Fix return value check in sparx5_serdes_probe()
In case of error, the function devm_ioremap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 2ff8a1eeb5aa ("phy: Add Sparx5 ethernet serdes PHY driver") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20210909072149.2934047-1-yangyingliang@huawei.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy/microchip')
-rw-r--r--drivers/phy/microchip/sparx5_serdes.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/phy/microchip/sparx5_serdes.c b/drivers/phy/microchip/sparx5_serdes.c
index 4076580fc2cd..ab1b0986aa67 100644
--- a/drivers/phy/microchip/sparx5_serdes.c
+++ b/drivers/phy/microchip/sparx5_serdes.c
@@ -2475,10 +2475,10 @@ static int sparx5_serdes_probe(struct platform_device *pdev)
return -EINVAL;
}
iomem = devm_ioremap(priv->dev, iores->start, resource_size(iores));
- if (IS_ERR(iomem)) {
+ if (!iomem) {
dev_err(priv->dev, "Unable to get serdes registers: %s\n",
iores->name);
- return PTR_ERR(iomem);
+ return -ENOMEM;
}
for (idx = 0; idx < ARRAY_SIZE(sparx5_serdes_iomap); idx++) {
struct sparx5_serdes_io_resource *iomap = &sparx5_serdes_iomap[idx];