diff options
| author | Dmitry Baryshkov <dmitry.baryshkov@linaro.org> | 2023-06-21 18:33:11 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2023-07-12 19:57:42 +0300 |
| commit | 6292fd920ee76f3e95fb580ced44831884942e05 (patch) | |
| tree | 86f711773a8ff93f84f34dc5fa8b94663e78cd62 /drivers/phy/qualcomm | |
| parent | 25d70083351318b44ae699d92c042dcb18a738ea (diff) | |
| download | linux-6292fd920ee76f3e95fb580ced44831884942e05.tar.xz | |
phy: qcom: qmp-combo: correct bias0_en programming
It seems the commit a2e927b0e50d ("phy: qcom-qmp-combo: Add sc8280xp
USB/DP combo phys") contained a typo for selecting bias0_en values.
First, bias0_en and bias1_en are expected to be symmetrical, and then
the vendor driver also uses `flipped : 0x3E : 0x15` statement for
bias0_en. Correct bias0_en programming to follow this.
Fixes: 49742e9edab3 ("phy: qcom-qmp-combo: Add support for SM8550")
Fixes: a2e927b0e50d ("phy: qcom-qmp-combo: Add sc8280xp USB/DP combo phys")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20230621153317.1025914-2-dmitry.baryshkov@linaro.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy/qualcomm')
| -rw-r--r-- | drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index d4f271b3c211..641307f6ee29 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -2322,7 +2322,7 @@ static int qmp_v5_configure_dp_phy(struct qmp_combo *qmp) return ret; if (dp_opts->lanes == 1) { - bias0_en = reverse ? 0x3e : 0x1a; + bias0_en = reverse ? 0x3e : 0x15; drvr0_en = reverse ? 0x13 : 0x10; bias1_en = reverse ? 0x15 : 0x3e; drvr1_en = reverse ? 0x10 : 0x13; @@ -2382,7 +2382,7 @@ static int qmp_v6_configure_dp_phy(struct qmp_combo *qmp) return ret; if (dp_opts->lanes == 1) { - bias0_en = reverse ? 0x3e : 0x1a; + bias0_en = reverse ? 0x3e : 0x15; drvr0_en = reverse ? 0x13 : 0x10; bias1_en = reverse ? 0x15 : 0x3e; drvr1_en = reverse ? 0x10 : 0x13; |