summaryrefslogtreecommitdiff
path: root/drivers/pinctrl/pinctrl-tb10x.c
diff options
context:
space:
mode:
authorChristian Ruppert <christian.ruppert@abilis.com>2014-04-11 18:46:04 +0400
committerLinus Walleij <linus.walleij@linaro.org>2014-04-22 16:55:02 +0400
commit4c5fba3d4ae3a7aae2c4a56d4a234aa556b7caca (patch)
tree9e91e1c94fa4e5f5f486edf5a0c61be122112f7a /drivers/pinctrl/pinctrl-tb10x.c
parenta798c10faf62a505d24e5f6213fbaf904a39623f (diff)
downloadlinux-4c5fba3d4ae3a7aae2c4a56d4a234aa556b7caca.tar.xz
pinctrl/TB10x: Fix signedness bug
In the TB10x pin database, a port index of -1 is used to indicate unmuxed GPIO pin groups. This bug fixes a 'cast to unsigned' bug of this value. Thanks to Dan Carpenter for highlighting this. CC: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Christian Ruppert <christian.ruppert@abilis.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-tb10x.c')
-rw-r--r--drivers/pinctrl/pinctrl-tb10x.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pinctrl/pinctrl-tb10x.c b/drivers/pinctrl/pinctrl-tb10x.c
index c5e0f6973a3b..26ca6855f478 100644
--- a/drivers/pinctrl/pinctrl-tb10x.c
+++ b/drivers/pinctrl/pinctrl-tb10x.c
@@ -629,9 +629,8 @@ static int tb10x_gpio_request_enable(struct pinctrl_dev *pctl,
*/
for (i = 0; i < state->pinfuncgrpcnt; i++) {
const struct tb10x_pinfuncgrp *pfg = &state->pingroups[i];
- unsigned int port = pfg->port;
unsigned int mode = pfg->mode;
- int j;
+ int j, port = pfg->port;
/*
* Skip pin groups which are always mapped and don't need