diff options
| author | Tzung-Bi Shih <tzungbi@kernel.org> | 2022-05-13 07:41:38 +0300 |
|---|---|---|
| committer | Tzung-Bi Shih <tzungbi@kernel.org> | 2022-05-16 05:01:51 +0300 |
| commit | 71d3ae7fb6404c87b498f8b7f86b8271dd74989f (patch) | |
| tree | 269112af14e973dfa6a424fd8a4bbd02e2b20d81 /drivers/platform/chrome/cros_ec_i2c.c | |
| parent | 42701e7c0cd2a715def2dafd22f11f25ca0f5024 (diff) | |
| download | linux-71d3ae7fb6404c87b498f8b7f86b8271dd74989f.tar.xz | |
platform/chrome: correct cros_ec_prepare_tx() usage
cros_ec_prepare_tx() returns either:
- >= 0 for number of prepared bytes.
- < 0 for -errno.
Correct the comment and make sure all callers check the return code.
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20220513044143.1045728-3-tzungbi@kernel.org
Diffstat (limited to 'drivers/platform/chrome/cros_ec_i2c.c')
| -rw-r--r-- | drivers/platform/chrome/cros_ec_i2c.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/platform/chrome/cros_ec_i2c.c b/drivers/platform/chrome/cros_ec_i2c.c index 22feb0fd4ce7..a4f305f1eb0e 100644 --- a/drivers/platform/chrome/cros_ec_i2c.c +++ b/drivers/platform/chrome/cros_ec_i2c.c @@ -89,6 +89,8 @@ static int cros_ec_pkt_xfer_i2c(struct cros_ec_device *ec_dev, ec_dev->dout++; ret = cros_ec_prepare_tx(ec_dev, msg); + if (ret < 0) + goto done; ec_dev->dout--; /* send command to EC and read answer */ |