summaryrefslogtreecommitdiff
path: root/drivers/platform/x86/siemens
diff options
context:
space:
mode:
authorxingtong.wu <xingtong.wu@siemens.com>2023-08-02 20:35:15 +0300
committerHans de Goede <hdegoede@redhat.com>2023-08-10 11:42:11 +0300
commitb01c1e022f7f0c327ecc7544dc44d5f80a2d2bd9 (patch)
treeff196a308a1c6d6153eeb240412adb6c0605d88d /drivers/platform/x86/siemens
parente5d5ffa48a6eadb67949590ca78c594836e2ae28 (diff)
downloadlinux-b01c1e022f7f0c327ecc7544dc44d5f80a2d2bd9.tar.xz
platform/x86/siemens: simatic-ipc: fix logical error for BX-59A
The variable "ledmode" is missing from if statement that leads to a logical error. Add the missing variable to the if condition. Fixes: b8af77951941 ("platform/x86/siemens: simatic-ipc: add new models BX-56A/BX-59A") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202307312322.Aa8upHWK-lkp@intel.com/ Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: xingtong.wu <xingtong.wu@siemens.com> Link: https://lore.kernel.org/r/20430802173515.2363-2-xingtong_wu@163.com Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/x86/siemens')
-rw-r--r--drivers/platform/x86/siemens/simatic-ipc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/siemens/simatic-ipc.c b/drivers/platform/x86/siemens/simatic-ipc.c
index 02c540cf4070..8ca6e277fa03 100644
--- a/drivers/platform/x86/siemens/simatic-ipc.c
+++ b/drivers/platform/x86/siemens/simatic-ipc.c
@@ -129,7 +129,7 @@ static int register_platform_devices(u32 station_id)
pdevname = KBUILD_MODNAME "_leds";
if (ledmode == SIMATIC_IPC_DEVICE_127E)
pdevname = KBUILD_MODNAME "_leds_gpio_apollolake";
- if (ledmode == SIMATIC_IPC_DEVICE_227G || SIMATIC_IPC_DEVICE_BX_59A)
+ if (ledmode == SIMATIC_IPC_DEVICE_227G || ledmode == SIMATIC_IPC_DEVICE_BX_59A)
pdevname = KBUILD_MODNAME "_leds_gpio_f7188x";
if (ledmode == SIMATIC_IPC_DEVICE_BX_21A)
pdevname = KBUILD_MODNAME "_leds_gpio_elkhartlake";