summaryrefslogtreecommitdiff
path: root/drivers/platform
diff options
context:
space:
mode:
authorLu Wei <luwei32@huawei.com>2020-07-10 12:30:18 +0300
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>2020-07-14 15:43:08 +0300
commit64dd4a5a7d214a07e3d9f40227ec30ac8ba8796e (patch)
tree154c77f3e4b50038726d8f180c148e821324c98e /drivers/platform
parent71fbe886ce6dd0be17f20aded9c63fe58edd2806 (diff)
downloadlinux-64dd4a5a7d214a07e3d9f40227ec30ac8ba8796e.tar.xz
platform/x86: intel-vbtn: Fix return value check in check_acpi_dev()
In the function check_acpi_dev(), if it fails to create platform device, the return value is ERR_PTR() or NULL. Thus it must use IS_ERR_OR_NULL() to check return value. Fixes: 332e081225fc ("intel-vbtn: new driver for Intel Virtual Button") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Lu Wei <luwei32@huawei.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Diffstat (limited to 'drivers/platform')
-rw-r--r--drivers/platform/x86/intel-vbtn.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
index 0487b606a274..e85d8e58320c 100644
--- a/drivers/platform/x86/intel-vbtn.c
+++ b/drivers/platform/x86/intel-vbtn.c
@@ -299,7 +299,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)
return AE_OK;
if (acpi_match_device_ids(dev, ids) == 0)
- if (acpi_create_platform_device(dev, NULL))
+ if (!IS_ERR_OR_NULL(acpi_create_platform_device(dev, NULL)))
dev_info(&dev->dev,
"intel-vbtn: created platform device\n");