summaryrefslogtreecommitdiff
path: root/drivers/pwm/pwm-bcm-kona.c
diff options
context:
space:
mode:
authorLee Jones <lee.jones@linaro.org>2020-06-29 15:47:50 +0300
committerThierry Reding <thierry.reding@gmail.com>2020-07-30 12:27:12 +0300
commit75de72591aa8ffa3acdc14cc1d3708ce8ac09245 (patch)
tree017201c952e264449b2c2ceee60adcbd2af2dedd /drivers/pwm/pwm-bcm-kona.c
parent9443f2c88ad916cad7efcd40fabc3e8c33c98594 (diff)
downloadlinux-75de72591aa8ffa3acdc14cc1d3708ce8ac09245.tar.xz
pwm: bcm-kona: Remove impossible comparison when validating duty cycle
'dc' here is an unsigned long, thus checking for <0 will always evaluate to false. Fixes the following W=1 warning: drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-pwm@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm/pwm-bcm-kona.c')
-rw-r--r--drivers/pwm/pwm-bcm-kona.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c
index 81da91df2529..16c5898b934a 100644
--- a/drivers/pwm/pwm-bcm-kona.c
+++ b/drivers/pwm/pwm-bcm-kona.c
@@ -138,7 +138,7 @@ static int kona_pwmc_config(struct pwm_chip *chip, struct pwm_device *pwm,
dc = div64_u64(val, div);
/* If duty_ns or period_ns are not achievable then return */
- if (pc < PERIOD_COUNT_MIN || dc < DUTY_CYCLE_HIGH_MIN)
+ if (pc < PERIOD_COUNT_MIN)
return -EINVAL;
/* If pc and dc are in bounds, the calculation is done */