summaryrefslogtreecommitdiff
path: root/drivers/regulator/act8865-regulator.c
diff options
context:
space:
mode:
authorMaarten ter Huurne <maarten@treewalker.org>2016-03-17 17:05:06 +0300
committerMark Brown <broonie@kernel.org>2016-03-21 20:52:07 +0300
commite6e79fd9cee682b137779d2da3b379251927d99f (patch)
tree3e004fa6fe4665a9176f6ca7c53ae44b51f8e199 /drivers/regulator/act8865-regulator.c
parentde14ba67378df74c6328f75fd6972ef83ed4639b (diff)
downloadlinux-e6e79fd9cee682b137779d2da3b379251927d99f.tar.xz
regulator: act8865: Remove "too many regulators" error handler
The check would dereference pdata, which can be NULL in the non-DT use case. Nothing will break if pdata->num_regulators is larger than the number of regulators that the driver defines: pdata->num_regulators is only read in act8865_get_init_data() to iterate through pdata->regulators. The error handler might have some value as a sanity check on the platform data, but the platform data could be broken in many other ways that are not checked for (unknown IDs, duplicate IDs), so I see no reason to perform only this specific check. Signed-off-by: Maarten ter Huurne <maarten@treewalker.org> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator/act8865-regulator.c')
-rw-r--r--drivers/regulator/act8865-regulator.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/drivers/regulator/act8865-regulator.c b/drivers/regulator/act8865-regulator.c
index 89f856f257f7..69cdad0f71ba 100644
--- a/drivers/regulator/act8865-regulator.c
+++ b/drivers/regulator/act8865-regulator.c
@@ -485,12 +485,6 @@ static int act8865_pmic_probe(struct i2c_client *client,
pdata = &pdata_of;
}
- if (pdata->num_regulators > num_regulators) {
- dev_err(dev, "too many regulators: %d\n",
- pdata->num_regulators);
- return -EINVAL;
- }
-
act8865 = devm_kzalloc(dev, sizeof(struct act8865), GFP_KERNEL);
if (!act8865)
return -ENOMEM;