diff options
| author | Colin Ian King <colin.king@canonical.com> | 2020-09-18 18:24:28 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-10-29 12:08:06 +0300 |
| commit | 83cf3166bd728e3258f1e544b971d133659a9674 (patch) | |
| tree | 60ab5b6980dcd6a709fe06adf3b20f861a8b00f2 /drivers/remoteproc/mtk_scp_ipi.c | |
| parent | 1642d9e7095c0da08b711ac05881385f9a4c51ff (diff) | |
| download | linux-83cf3166bd728e3258f1e544b971d133659a9674.tar.xz | |
remoteproc/mediatek: fix null pointer dereference on null scp pointer
[ Upstream commit 434ac4d51407ce3764a6ae96a89d90b8ae2826fb ]
Currently when pointer scp is null a dev_err is being called that
references the pointer which is the very thing we are trying to
avoid doing. Remove the extraneous error message to avoid this
issue.
Addresses-Coverity: ("Dereference after null check")
Fixes: 63c13d61eafe ("remoteproc/mediatek: add SCP support for mt8183")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200918152428.27258-1-colin.king@canonical.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/remoteproc/mtk_scp_ipi.c')
| -rw-r--r-- | drivers/remoteproc/mtk_scp_ipi.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/remoteproc/mtk_scp_ipi.c b/drivers/remoteproc/mtk_scp_ipi.c index 3d3d87210ef2..58d1d7e571d6 100644 --- a/drivers/remoteproc/mtk_scp_ipi.c +++ b/drivers/remoteproc/mtk_scp_ipi.c @@ -30,10 +30,8 @@ int scp_ipi_register(struct mtk_scp *scp, scp_ipi_handler_t handler, void *priv) { - if (!scp) { - dev_err(scp->dev, "scp device is not ready\n"); + if (!scp) return -EPROBE_DEFER; - } if (WARN_ON(id >= SCP_IPI_MAX) || WARN_ON(handler == NULL)) return -EINVAL; |