summaryrefslogtreecommitdiff
path: root/drivers/reset/core.c
diff options
context:
space:
mode:
authorPhilipp Zabel <p.zabel@pengutronix.de>2021-06-07 11:26:15 +0300
committerPhilipp Zabel <p.zabel@pengutronix.de>2021-06-07 12:26:31 +0300
commit4fb26fb83f0def3d39c14e268bcd4003aae8fade (patch)
tree49589e55f098e2c04ac377eb6a5fdb222da99614 /drivers/reset/core.c
parent91105ed604e4ea7075a35a1ef8bc1782d347290e (diff)
downloadlinux-4fb26fb83f0def3d39c14e268bcd4003aae8fade.tar.xz
reset: bail if try_module_get() fails
Abort instead of returning a new reset control for a reset controller device that is going to have its module unloaded. Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Fixes: 61fc41317666 ("reset: Add reset controller API") Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20210607082615.15160-1-p.zabel@pengutronix.de Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Diffstat (limited to 'drivers/reset/core.c')
-rw-r--r--drivers/reset/core.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/reset/core.c b/drivers/reset/core.c
index 63852076a5a3..61e688882643 100644
--- a/drivers/reset/core.c
+++ b/drivers/reset/core.c
@@ -774,7 +774,10 @@ __reset_control_get_internal(struct reset_controller_dev *rcdev,
if (!rstc)
return ERR_PTR(-ENOMEM);
- try_module_get(rcdev->owner);
+ if (!try_module_get(rcdev->owner)) {
+ kfree(rstc);
+ return ERR_PTR(-ENODEV);
+ }
rstc->rcdev = rcdev;
list_add(&rstc->list, &rcdev->reset_control_head);