summaryrefslogtreecommitdiff
path: root/drivers/rtc/rtc-max77686.c
diff options
context:
space:
mode:
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>2016-02-04 03:26:35 +0300
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>2016-02-05 01:44:14 +0300
commitfb166ba1d7f0a662f7332f4ff660a0d6f4d76915 (patch)
tree3d559251aec9b2bc37e4c63095803cd7b542821c /drivers/rtc/rtc-max77686.c
parent1e5813bded3c6702841549ac2533680f410aea43 (diff)
downloadlinux-fb166ba1d7f0a662f7332f4ff660a0d6f4d76915.tar.xz
rtc: max77686: Properly handle regmap_irq_get_virq() error code
The regmap_irq_get_virq() can return 0 or -EINVAL in error conditions but driver checked only for value of 0. This could lead to a cast of -EINVAL to an unsigned int used as a interrupt number for devm_request_threaded_irq(). Although this is not yet fatal (devm_request_threaded_irq() will just fail with -EINVAL) but might be a misleading when diagnosing errors. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Fixes: 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq") Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Diffstat (limited to 'drivers/rtc/rtc-max77686.c')
-rw-r--r--drivers/rtc/rtc-max77686.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index bbb06dd2ee35..d2d1176a1f60 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -667,7 +667,7 @@ static int max77686_rtc_probe(struct platform_device *pdev)
info->virq = regmap_irq_get_virq(max77686->rtc_irq_data,
MAX77686_RTCIRQ_RTCA1);
- if (!info->virq) {
+ if (info->virq <= 0) {
ret = -ENXIO;
goto err_rtc;
}