summaryrefslogtreecommitdiff
path: root/drivers/rtc
diff options
context:
space:
mode:
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>2022-07-07 18:31:56 +0300
committerAlexandre Belloni <alexandre.belloni@bootlin.com>2022-07-26 17:43:46 +0300
commit5c9f41443e8d5fbd414ad0dfa8e0996b937d135a (patch)
tree601ccdd459576d85a9aece00f64bdf8e52ad0b78 /drivers/rtc
parent2a692245b6de1f17baef24db46fed03186ff3cc3 (diff)
downloadlinux-5c9f41443e8d5fbd414ad0dfa8e0996b937d135a.tar.xz
rtc: cros-ec: Only warn once in .remove() about notifier_chain problems
When a remove platform device callback returns an error code, the driver core emits an error message ("remove callback returned a non-zero value. This will be ignored.\n") and still removes the device. As the driver already emits a more specific error message, return 0 to suppress the core's error message. This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Tzung-Bi Shih <tzungbi@kernel.org> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20220707153156.214841-1-u.kleine-koenig@pengutronix.de
Diffstat (limited to 'drivers/rtc')
-rw-r--r--drivers/rtc/rtc-cros-ec.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/rtc/rtc-cros-ec.c b/drivers/rtc/rtc-cros-ec.c
index 70626793ca69..887f5193e253 100644
--- a/drivers/rtc/rtc-cros-ec.c
+++ b/drivers/rtc/rtc-cros-ec.c
@@ -375,10 +375,8 @@ static int cros_ec_rtc_remove(struct platform_device *pdev)
ret = blocking_notifier_chain_unregister(
&cros_ec_rtc->cros_ec->event_notifier,
&cros_ec_rtc->notifier);
- if (ret) {
+ if (ret)
dev_err(dev, "failed to unregister notifier\n");
- return ret;
- }
return 0;
}