summaryrefslogtreecommitdiff
path: root/drivers/s390/crypto
diff options
context:
space:
mode:
authorNiklas Schnelle <schnelle@linux.ibm.com>2021-01-19 10:49:37 +0300
committerVasily Gorbik <gor@linux.ibm.com>2021-01-27 15:00:48 +0300
commite1bff843cde62a45a287b7f9b4cd5e824e8e49e2 (patch)
tree24305016e1ad95c771b54242a9279361516faff9 /drivers/s390/crypto
parentc1971eae30cfc0c239ffb9bb3152d750854e05f2 (diff)
downloadlinux-e1bff843cde62a45a287b7f9b4cd5e824e8e49e2.tar.xz
s390/pci: remove superfluous zdev->zbus check
Checking zdev->zbus for NULL in __zpci_event_availability() is superfluous as it can never be NULL at this point. While harmless this check causes smatch warnings because we later access zdev->zbus with only having checked zdev != NULL which is sufficient. The reason zdev->zbus can never be NULL is since with zdev != NULL given we know the zdev came from get_zdev_by_fid() and thus the zpci_list. Now on first glance at zpci_create_device() one may assume that there is a window where the zdev is in the list without a zdev, however this window can't overlap with __zpci_event_availability() as zpci_create_device() either runs on the same kthread as part of availability events, or during the initial CLP List PCI at which point the __zpci_event_availability() is not yet called as zPCI is not yet initialized. Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com> Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Diffstat (limited to 'drivers/s390/crypto')
0 files changed, 0 insertions, 0 deletions