diff options
author | Chao Song <chao.song@linux.intel.com> | 2023-05-15 11:13:01 +0300 |
---|---|---|
committer | Vinod Koul <vkoul@kernel.org> | 2023-05-27 13:38:48 +0300 |
commit | 3d912d1a28da59a95e046feff3ea2bc38e00138e (patch) | |
tree | 5570298242bc4ecae942cf32b9d7e327ff08d402 /drivers/soundwire/sysfs_local.h | |
parent | 6dd0776ddde8ae187c04803c53becd55eccf4fc3 (diff) | |
download | linux-3d912d1a28da59a95e046feff3ea2bc38e00138e.tar.xz |
soundwire: intel: read AC timing control register before updating it
Start from ACE1.x, DOAISE is added to AC timing control
register bit 5, it combines with DOAIS to get effective
timing, and has the default value 1.
The current code fills DOAIS, DACTQE and DODS bits to a
variable initialized to zero, and updates the variable
to AC timing control register. With this operation, We
change DOAISE to 0, and force a much more aggressive
timing. The timing is even unable to form a working
waveform on SDA pin on Meteorlake.
This patch uses read-modify-write operation for the AC
timing control register access, thus makes sure those
bits not supposed and intended to change are not touched.
Signed-off-by: Chao Song <chao.song@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20230515081301.12921-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/soundwire/sysfs_local.h')
0 files changed, 0 insertions, 0 deletions