diff options
| author | Johan Hovold <johan@hovoldconsulting.com> | 2016-07-21 13:48:57 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@google.com> | 2016-07-21 20:07:00 +0300 |
| commit | b5d1d1282bbb318a67fdcfc8ef2615e93d1d1724 (patch) | |
| tree | c79dd5fec7d9190fe7fde6444d97d6c178a85a45 /drivers/staging/greybus/interface.c | |
| parent | 10a24b7c0911d63c7342dfb860e939221b4a9465 (diff) | |
| download | linux-b5d1d1282bbb318a67fdcfc8ef2615e93d1d1724.tar.xz | |
greybus: interface: fix interface_id attribute group
All interfaces, regardless of type, should have an interface_id
attribute reflecting its position on the frame.
This has been reported to cause an assertion failure in libmoduleutil
for dummy modules.
Testing done: Verified that the attribute is present for registered
dummy interfaces.
Reported-by: Gjorgji Rosikopulos <grosikopulos@mm-sol.com>
Tested-by: Gjorgji Rosikopulos <grosikopulos@mm-sol.com>
Reviewed-by: Patrick Titiano <ptitiano@baylibre.com>
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
Diffstat (limited to 'drivers/staging/greybus/interface.c')
| -rw-r--r-- | drivers/staging/greybus/interface.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/greybus/interface.c b/drivers/staging/greybus/interface.c index 919eaa0a46c7..6abe1311058f 100644 --- a/drivers/staging/greybus/interface.c +++ b/drivers/staging/greybus/interface.c @@ -587,7 +587,6 @@ static struct attribute *interface_unipro_attrs[] = { }; static struct attribute *interface_greybus_attrs[] = { - &dev_attr_interface_id.attr, &dev_attr_vendor_id.attr, &dev_attr_product_id.attr, &dev_attr_serial_number.attr, @@ -603,6 +602,7 @@ static struct attribute *interface_power_attrs[] = { }; static struct attribute *interface_common_attrs[] = { + &dev_attr_interface_id.attr, &dev_attr_interface_type.attr, NULL }; |