summaryrefslogtreecommitdiff
path: root/drivers/staging/line6/podhd.c
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@gmail.com>2011-12-10 05:12:30 +0400
committerGreg Kroah-Hartman <gregkh@suse.de>2011-12-10 07:26:09 +0400
commit188e664502dc47f83775a556e6db52cd8cc0b5fc (patch)
tree146739a24800d2e99ba018274bcf7aea508e1da9 /drivers/staging/line6/podhd.c
parent153e38761d27f29edf436f11da3dbfb4fb8edcc1 (diff)
downloadlinux-188e664502dc47f83775a556e6db52cd8cc0b5fc.tar.xz
staging: line6: eliminate useless NULL checks
The line6 driver checks struct field addresses for NULL where it does not make sense to do so. The struct has already been checked for NULL and there is no value in checking the first field's address too. Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com> Signed-off-by: Markus Grabner <grabner@icg.tugraz.at> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/line6/podhd.c')
-rw-r--r--drivers/staging/line6/podhd.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/staging/line6/podhd.c b/drivers/staging/line6/podhd.c
index 6c0f7f21c248..7ef45437b4f2 100644
--- a/drivers/staging/line6/podhd.c
+++ b/drivers/staging/line6/podhd.c
@@ -80,14 +80,10 @@ static struct line6_pcm_properties podhd_pcm_properties = {
static void podhd_destruct(struct usb_interface *interface)
{
struct usb_line6_podhd *podhd = usb_get_intfdata(interface);
- struct usb_line6 *line6;
if (podhd == NULL)
return;
- line6 = &podhd->line6;
- if (line6 == NULL)
- return;
- line6_cleanup_audio(line6);
+ line6_cleanup_audio(&podhd->line6);
}
/*