diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2023-05-11 17:51:21 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2023-06-09 16:35:03 +0300 |
| commit | 820a1338d6a14bde0de7ed57cf486c31798a9619 (patch) | |
| tree | ed90677e21a7ee2d95c38e4692cf1d10efbf9a36 /drivers/staging/media/atomisp/pci/atomisp_internal.h | |
| parent | fb86cf8bd8a94981be5c0f4263f31e43e1aaf445 (diff) | |
| download | linux-820a1338d6a14bde0de7ed57cf486c31798a9619.tar.xz | |
media: atomisp: Remove isp_timeout flag
isp_timeout only ever gets set in __atomisp_css_recover() and then
immediately gets cleared again after calling atomisp_reset().
All this happens with isp->mutex held.
The only consumer of isp->isp_timeout is atomisp_stop_streaming(), which
also holds isp->mutex and which is *not* called by atomisp_reset().
Since both hold isp->mutex and since __atomisp_css_recover() clears
isp_timeout before releasing the mutex, atomisp_stop_streaming() can
never see isp_timeout being true, so just remove the flag.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/staging/media/atomisp/pci/atomisp_internal.h')
| -rw-r--r-- | drivers/staging/media/atomisp/pci/atomisp_internal.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/staging/media/atomisp/pci/atomisp_internal.h b/drivers/staging/media/atomisp/pci/atomisp_internal.h index cec0ac92726e..3d4f0f632f44 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_internal.h +++ b/drivers/staging/media/atomisp/pci/atomisp_internal.h @@ -204,8 +204,6 @@ struct atomisp_device { struct atomisp_regs saved_regs; struct atomisp_css_env css_env; - /* isp timeout status flag */ - bool isp_timeout; bool isp_fatal_error; struct work_struct assert_recovery_work; |