diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2023-12-30 17:37:54 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@kernel.org> | 2024-02-01 09:05:08 +0300 |
| commit | ace440e6db33330b40afbb7c2c85a6b1399f3baa (patch) | |
| tree | b2c97f8331011981feab38acb0f972fab140ae2a /drivers/staging/media/atomisp/pci/atomisp_v4l2.c | |
| parent | a6be73e97facfdc1d4e3117afcbc6fdbaeae7726 (diff) | |
| download | linux-ace440e6db33330b40afbb7c2c85a6b1399f3baa.tar.xz | |
media: atomisp: Remove unnecessary msleep(10) from atomisp_mrfld_power() error path
Remove unnecessary msleep(10) from atomisp_mrfld_power() error-exit path,
the success exit from atomisp_mrfld_power() happens if a test succeeds
inside the do { } while loop above the msleep().
The error-exit path with the removed msleep is only hit it the power-on is
not reflected in the iUNIT ISPSSPM0 status bits after a timeout of 50 ms.
Sleeping an extra 10 ms in the timeout path makes little sense.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Diffstat (limited to 'drivers/staging/media/atomisp/pci/atomisp_v4l2.c')
| -rw-r--r-- | drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c index 7e241f4e9e93..f736e54c7df3 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -587,9 +587,6 @@ static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) usleep_range(100, 150); } while (1); - if (enable) - msleep(10); - dev_err(isp->dev, "IUNIT power-%s timeout.\n", enable ? "on" : "off"); return -EBUSY; } |