summaryrefslogtreecommitdiff
path: root/drivers/staging/pi433
diff options
context:
space:
mode:
authorPaulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>2022-01-19 02:04:13 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-01-25 18:33:55 +0300
commitd9dc6c1b440f837135af579c3caa4c27b0e0105b (patch)
tree122ee224e710b95b81e212fbbad7cbe00ed79e24 /drivers/staging/pi433
parente12592158515831e5ff6e80a36a4d05ceaf22908 (diff)
downloadlinux-d9dc6c1b440f837135af579c3caa4c27b0e0105b.tar.xz
staging: pi433: fix validation for min bit rate supported by the device
rf69 datasheets establishes that the minimum supported bit rate is 1.2 kbps regardless of modulation. this patch replaces the errouneous validation with the correct value Acked-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com> Link: https://lore.kernel.org/r/20220118230413.GA4859@mail.google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/pi433')
-rw-r--r--drivers/staging/pi433/rf69.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index ee8c81d164e1..f4ac17adcd83 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -226,14 +226,12 @@ int rf69_set_modulation_shaping(struct spi_device *spi,
int rf69_set_bit_rate(struct spi_device *spi, u16 bit_rate)
{
int retval;
- u32 bit_rate_min;
u32 bit_rate_reg;
u8 msb;
u8 lsb;
// check input value
- bit_rate_min = F_OSC / 8388608; // 8388608 = 2^23;
- if (bit_rate < bit_rate_min) {
+ if (bit_rate < 1200) {
dev_dbg(&spi->dev, "setBitRate: illegal input param");
return -EINVAL;
}