diff options
author | Alan Cox <alan@linux.intel.com> | 2009-08-14 18:42:18 +0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2009-09-15 23:02:15 +0400 |
commit | 70ae04e6cc38454187c9ade023f2bdce474e6936 (patch) | |
tree | 6aff3ac60c5ad20714625d9f99a17c5cf6adac06 /drivers/staging/sep/sep_dev.h | |
parent | 4c29e9799878b6a5fc9ec37d40132c2380911e0f (diff) | |
download | linux-70ae04e6cc38454187c9ade023f2bdce474e6936.tar.xz |
Staging: sep: kick out various fields we can prove are not needed
#1: sep->cache_addr is assigned to sep->rar_addr and never changed
sep->rar_addr is never assigned after this point
#2: sep->cache_bus ditto for sep->rar_bus
#3 sep->rar_region_addr is assigned but necer used
#4 sep->io_addr is in fact private to the probe function and
the same as the reg_addr
#5 The remainig sep->io fields are in fact function locals
#6 sep->message_shared_area is assigned once from sep->shared_area
sep->shared_area does not then change
#7 sep->shared_addr and sep->shared_area_addr are the same thing, ditto
for the bus addresses.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/sep/sep_dev.h')
-rw-r--r-- | drivers/staging/sep/sep_dev.h | 30 |
1 files changed, 8 insertions, 22 deletions
diff --git a/drivers/staging/sep/sep_dev.h b/drivers/staging/sep/sep_dev.h index d4f0a69e0fcb..9200524bb64d 100644 --- a/drivers/staging/sep/sep_dev.h +++ b/drivers/staging/sep/sep_dev.h @@ -34,30 +34,23 @@ struct sep_device { unsigned long in_use; - unsigned long io_bus; - unsigned long io_end_bus; - unsigned long io_memory_size; - void __iomem *io_addr; + /* address of the shared memory allocated during init for SEP driver + (coherent alloc) */ + void *shared_addr; + /* the physical address of the shared area */ + dma_addr_t shared_bus; - /* restricted access region */ + /* restricted access region (coherent alloc) */ dma_addr_t rar_bus; void *rar_addr; - - /* shared memory region */ - dma_addr_t shared_bus; - void *shared_addr; - - /* firmware regions */ - dma_addr_t cache_bus; + /* firmware regions: cache is at rar_addr */ unsigned long cache_size; - void *cache_addr; + /* follows the cache */ dma_addr_t resident_bus; unsigned long resident_size; void *resident_addr; - void *rar_region_addr; - /* start address of the access to the SEP registers from driver */ void __iomem *reg_addr; /* transaction counter that coordinates the transactions between SEP and HOST */ @@ -88,13 +81,6 @@ struct sep_device { /* pointer to the workqueue that handles the flow done interrupts */ struct workqueue_struct *flow_wq; - /* address of the shared memory allocated during init for SEP driver */ - void *shared_area; - /* the physical address of the shared area */ - dma_addr_t shared_area_bus; - - /* Message Shared Area start address - will be allocated during init */ - void *message_shared_area_addr; }; static struct sep_device *sep_dev; |