diff options
| author | Mihaela Muraru <mihaela.muraru21@gmail.com> | 2016-10-06 11:07:44 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-10-16 11:24:18 +0300 |
| commit | 9872fa751e0bad862161c442d44b7ea597e23676 (patch) | |
| tree | e908e11726e526bb3976321492d07751b3e13987 /drivers/staging/sm750fb/ddk750_chip.c | |
| parent | e0cb35095753c038f42d1b6bf68c4cd063b3fd21 (diff) | |
| download | linux-9872fa751e0bad862161c442d44b7ea597e23676.tar.xz | |
Staging: sm750fb: fix do not add new typedefs warning
This patch fixes the checkpatch.pl warning: "WARNING: do not add new
typedefs". Hiding a variables of type 'struct' is not always a good
idea,because when we passing them as parameters we tempt to forget that
in this proces we work with stack memory and allocatting struct on
stack is something that we should manage carefuly.
It is also delete the '_t' from the name of the structs and treat a line
over 80 character issue in ddk750_mode.c, that appear after my modification.
Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/sm750fb/ddk750_chip.c')
| -rw-r--r-- | drivers/staging/sm750fb/ddk750_chip.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index 839d6730bde9..c62ebc159236 100644 --- a/drivers/staging/sm750fb/ddk750_chip.c +++ b/drivers/staging/sm750fb/ddk750_chip.c @@ -54,7 +54,7 @@ static unsigned int get_mxclk_freq(void) */ static void setChipClock(unsigned int frequency) { - pll_value_t pll; + struct pll_value pll; unsigned int ulActualMxClk; /* Cheok_0509: For SM750LE, the chip clock is fixed. Nothing to set. */ @@ -206,7 +206,7 @@ unsigned int ddk750_getVMSize(void) return data; } -int ddk750_initHw(initchip_param_t *pInitParam) +int ddk750_initHw(struct initchip_param *pInitParam) { unsigned int reg; @@ -305,7 +305,7 @@ int ddk750_initHw(initchip_param_t *pInitParam) * M = {1,...,255} * N = {2,...,15} */ -unsigned int calcPllValue(unsigned int request_orig, pll_value_t *pll) +unsigned int calcPllValue(unsigned int request_orig, struct pll_value *pll) { /* as sm750 register definition, * N located in 2,15 and M located in 1,255 @@ -373,7 +373,7 @@ unsigned int calcPllValue(unsigned int request_orig, pll_value_t *pll) return ret; } -unsigned int formatPllReg(pll_value_t *pPLL) +unsigned int formatPllReg(struct pll_value *pPLL) { #ifndef VALIDATION_CHIP unsigned int POD = pPLL->POD; |