diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2024-02-11 15:27:10 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-02-17 19:29:05 +0300 |
| commit | cfd87832dfa1b69069d3e6c598044a5568e1a1ef (patch) | |
| tree | 214abd1da909d1d8299c928c5876cb134aab479e /drivers/staging | |
| parent | 72c068a1c71ffac8d522ad50beda775b45cd5953 (diff) | |
| download | linux-cfd87832dfa1b69069d3e6c598044a5568e1a1ef.tar.xz | |
staging: axis-fifo: Use sysfs_emit()
sysfs_read() is anly called from _show() functions declared by
DEVICE_ATTR_RW().
Using sysfs_emit() is the preferred style and here, it saves a useless
copy and a temporary buffer in the stack.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/588327734f374b5f5cb5c4d5725d884fdc83663e.1707654406.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/axis-fifo/axis-fifo.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index 727b956aa231..c51818c56dd2 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -165,14 +165,9 @@ static ssize_t sysfs_read(struct device *dev, char *buf, { struct axis_fifo *fifo = dev_get_drvdata(dev); unsigned int read_val; - unsigned int len; - char tmp[32]; read_val = ioread32(fifo->base_addr + addr_offset); - len = snprintf(tmp, sizeof(tmp), "0x%x\n", read_val); - memcpy(buf, tmp, len); - - return len; + return sysfs_emit(buf, "0x%x\n", read_val); } static ssize_t isr_store(struct device *dev, struct device_attribute *attr, |