summaryrefslogtreecommitdiff
path: root/drivers/target/target_core_configfs.c
diff options
context:
space:
mode:
authorAndy Grover <agrover@redhat.com>2015-07-09 19:56:48 +0300
committerNicholas Bellinger <nab@linux-iscsi.org>2015-07-24 09:40:01 +0300
commit9105bfc038ca5a506404ce37cd3c0e85f76351e3 (patch)
tree8305c3941716f78b6b7c46cbac6f1afa1a13f720 /drivers/target/target_core_configfs.c
parentbc1a7d6aff763ea29db6319185327f86b0fe93b6 (diff)
downloadlinux-9105bfc038ca5a506404ce37cd3c0e85f76351e3.tar.xz
target: Do not return 0 from aptpl and alua configfs store functions
Here are some more instances where we are returning 0 from a configfs store function, the unintended result of which is likely infinite retries from userspace. Signed-off-by: Andy Grover <agrover@redhat.com> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/target_core_configfs.c')
-rw-r--r--drivers/target/target_core_configfs.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index cb09e6988b56..7f3cb3a2b783 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -1590,9 +1590,9 @@ static ssize_t target_core_dev_pr_store_attr_res_aptpl_metadata(
u8 type = 0;
if (dev->transport->transport_flags & TRANSPORT_FLAG_PASSTHROUGH)
- return 0;
+ return count;
if (dev->dev_reservation_flags & DRF_SPC2_RESERVATIONS)
- return 0;
+ return count;
if (dev->export_count) {
pr_debug("Unable to process APTPL metadata while"
@@ -1985,7 +1985,7 @@ static ssize_t target_core_store_alua_lu_gp(
lu_gp_mem = dev->dev_alua_lu_gp_mem;
if (!lu_gp_mem)
- return 0;
+ return count;
if (count > LU_GROUP_NAME_BUF) {
pr_err("ALUA LU Group Alias too large!\n");