summaryrefslogtreecommitdiff
path: root/drivers/thermal
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2021-05-27 12:26:40 +0300
committerDaniel Lezcano <daniel.lezcano@linaro.org>2021-05-27 12:38:34 +0300
commit5d8db38ad7660e4d78f4e2a63f14336f31f07a63 (patch)
treeb5b3677c1516beb324f770c480f0b438bb6cffb0 /drivers/thermal
parent8d84733dee9f7dfa7a323c59e9bd61b2a83bee3f (diff)
downloadlinux-5d8db38ad7660e4d78f4e2a63f14336f31f07a63.tar.xz
thermal/drivers/qcom: Fix error code in adc_tm5_get_dt_channel_data()
Return -EINVAL when args is invalid instead of 'ret' which is set to zero by a previous successful call to a function. Fixes: ca66dca5eda6 ("thermal: qcom: add support for adc-tm5 PMIC thermal monitor") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20210527092640.2070555-1-yangyingliang@huawei.com
Diffstat (limited to 'drivers/thermal')
-rw-r--r--drivers/thermal/qcom/qcom-spmi-adc-tm5.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
index b460b56e981c..232fd0b33325 100644
--- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
+++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
@@ -441,7 +441,7 @@ static int adc_tm5_get_dt_channel_data(struct adc_tm5_chip *adc_tm,
if (args.args_count != 1 || args.args[0] >= ADC5_MAX_CHANNEL) {
dev_err(dev, "%s: invalid ADC channel number %d\n", name, chan);
- return ret;
+ return -EINVAL;
}
channel->adc_channel = args.args[0];