summaryrefslogtreecommitdiff
path: root/drivers/tty
diff options
context:
space:
mode:
authorJonathan Cameron <Jonathan.Cameron@huawei.com>2020-06-07 18:53:53 +0300
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2020-07-05 16:22:48 +0300
commit5c49056ad9f3c786f7716da2dd47e4488fc6bd25 (patch)
tree4e65f7598d452337bee376fb8235f26e80fa05cb /drivers/tty
parentea5e7a7bb6205d24371373cd80325db1bc15eded (diff)
downloadlinux-5c49056ad9f3c786f7716da2dd47e4488fc6bd25.tar.xz
iio:humidity:hts221 Fix alignment and data leak issues
One of a class of bugs pointed out by Lars in a recent review. iio_push_to_buffers_with_timestamp assumes the buffer used is aligned to the size of the timestamp (8 bytes). This is not guaranteed in this driver which uses an array of smaller elements on the stack. As Lars also noted this anti pattern can involve a leak of data to userspace and that indeed can happen here. We close both issues by moving to a suitable structure in the iio_priv() data. This data is allocated with kzalloc so no data can leak apart from previous readings. Explicit alignment of ts needed to ensure consistent padding on all architectures (particularly x86_32 with it's 4 byte alignment of s64) Fixes: e4a70e3e7d84 ("iio: humidity: add support to hts221 rh/temp combo device") Reported-by: Lars-Peter Clausen <lars@metafoo.de> Acked-by: Lorenzo Bianconi <lorenzo@kernel.org> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: <Stable@vger.kernel.org>
Diffstat (limited to 'drivers/tty')
0 files changed, 0 insertions, 0 deletions