diff options
| author | Liu Jian <liujian56@huawei.com> | 2019-01-23 01:45:37 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-01-27 16:50:16 +0300 |
| commit | 3b656e7c166d14d8cb6acecd26e5761274ba2b73 (patch) | |
| tree | 086734e8bd814a9651e4eb5f0052c022cc150a85 /drivers/uio | |
| parent | 1dedc9d9269ad7f27b15996532c629e692e5aa1d (diff) | |
| download | linux-3b656e7c166d14d8cb6acecd26e5761274ba2b73.tar.xz | |
driver: uio: fix possible memory leak in __uio_register_device
[ Upstream commit 1a392b3de7c5747506b38fc14b2e79977d3c7770 ]
'idev' is malloced in __uio_register_device() and leak free it before
leaving from the uio_get_minor() error handing case, it will cause
memory leak.
Fixes: a93e7b331568 ("uio: Prevent device destruction while fds are open")
Signed-off-by: Liu Jian <liujian56@huawei.com>
Reviewed-by: Hamish Martin <hamish.martin@alliedtelesis.co.nz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/uio')
| -rw-r--r-- | drivers/uio/uio.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index 2762148c169d..e4b418757017 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -938,8 +938,10 @@ int __uio_register_device(struct module *owner, atomic_set(&idev->event, 0); ret = uio_get_minor(idev); - if (ret) + if (ret) { + kfree(idev); return ret; + } idev->dev.devt = MKDEV(uio_major, idev->minor); idev->dev.class = &uio_class; |